Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: bazelize rpc_gen_cycling_test #24400

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

rpc: bazelize rpc_gen_cycling_test #24400

wants to merge 4 commits into from
+325 −22

Conversation

IoannisRP
Copy link
Contributor

@IoannisRP IoannisRP commented Dec 2, 2024 •
edited by jira bot
Loading

Implements:
CORE-7594 : rpc_gen_cycling_test.cc

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Dec 2, 2024 •
edited
Loading

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/59130#0193894b-3fad-453d-8464-4814f5197a37
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/59130#01938950-6d1f-4c73-98d0-6f72f1ce3cff
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/59165#01938cbc-f919-4a82-9dfa-2d5a1e271c9d

@dotnwat
Copy link
Member

dotnwat commented Dec 3, 2024

i thought cpu!=1 might have been to blame, but that looks ok. maybe it needs tags = ["exclusive"]?

DEBUG 2024-12-02 23:07:25,547 [shard 0:main] dns_resolver - Query name 127.0.0.1 (ANY)
--
  | TRACE 2024-12-02 23:07:25,548 [shard 0:main] rpc - server.cc:262 - vectorized internal rpc protocol - Incoming connection from 127.0.0.1:60972 on ""
  | TRACE 2024-12-02 23:07:25,549 [shard 0:main] rpc - transport.cc:358 - Dispatched request with sequence: 1, correlation_idx: 1, pending queue_size: 0, target_address: {host: 127.0.0.1, port: 32147}
  | Segmentation fault on shard 0.
  | Backtrace:

@rockwotj
Copy link
Contributor

rockwotj commented Dec 3, 2024

It does need to be marked exclusive, but I wouldn't expect a segfault from that...

rockwotj
rockwotj reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@rockwotj rockwotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks marvelous - just a few things. The cert gen macros are chefs kiss so well done

src/v/rpc/compiler.bzl Outdated Show resolved Hide resolved
bazel/cert.bzl Outdated Show resolved Hide resolved
bazel/cert.bzl Show resolved Hide resolved
bazel/cert.bzl Outdated Show resolved Hide resolved
src/v/rpc/test/BUILD Outdated Show resolved Hide resolved
@IoannisRP
Copy link
Contributor Author

  • Added exclusive tag to rpc_gen_cycling_test
  • Added visibility parameters to certificate rules
  • Renamed json_deps -> deps

@IoannisRP
Copy link
Contributor Author

turns out the segmentation is not related to exclusive... looking into it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockwotj rockwotj rockwotj left review comments

@dotnwat dotnwat Awaiting requested review from dotnwat

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/build area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IoannisRP @vbotbuildovich @dotnwat @rockwotj